Fix Grafana teams sync #1652
Merged
Fix Grafana teams sync #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstpme
commented
Mar 28, 2023
| ) | ||
|
|
||
| team = models.ForeignKey( | ||
| "user_management.Team", | ||
| on_delete=models.SET_NULL, | ||
| on_delete=NON_POLYMORPHIC_SET_NULL, |
| @@ -15,3 +16,23 @@ def get_random_readonly_database_key_if_present_otherwise_default() -> str: | |||
| if hasattr(settings, "READONLY_DATABASES") and len(settings.READONLY_DATABASES) > 0: | |||
| using_db = random.choice(list(settings.READONLY_DATABASES.keys())) | |||
| return using_db | |||
|
|
|||
|
|
|||
| def NON_POLYMORPHIC_SET_NULL(collector, field, sub_objs, using): | |||
matiasb
approved these changes
Mar 28, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Sometimes plugin sync fails with the following exception:
How to reproduce:
This happens because the
OnCallScheduleDjango model is a polymorphic model and there's a known bug indjango-polymorphicwith deleting related objects when usingon_delete=SET_NULLandon_delete=CASCADE. This PR adds non-polymorphic versions ofSET_NULLandCASCADEto use in schedule FKs as per this comment.This also applies to two other schedule FKs:
organizationanduser_group, which are not working properly as well.Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)