Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update apns payload with corrected interruption-level field #1646

Merged
merged 6 commits into from
Mar 28, 2023
Merged

Update apns payload with corrected interruption-level field #1646

merged 6 commits into from
Mar 28, 2023

Conversation

imtoori
Copy link
Contributor

@imtoori imtoori commented Mar 28, 2023

I just noticed that ios notifications are always critical, even when the switch ("override DND") is set to false. I believe this is because critical should be either 1 or 0
https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/generating_a_remote_notification#2990112

@imtoori imtoori requested a review from a team March 28, 2023 08:14
@joeyorlando joeyorlando added the pr:no public docs Added to a PR that does not require public documentation updates label Mar 28, 2023
@joeyorlando joeyorlando enabled auto-merge March 28, 2023 08:37
@vstpme vstpme disabled auto-merge March 28, 2023 08:46
@vstpme
Copy link
Member

vstpme commented Mar 28, 2023

I disabled auto-merge to make sure we track the root cause, I think this is not related to critical flag not being 0/1. It currently works for non-important push notifications, so I think there's some other issue.

vstpme
vstpme reviewed Mar 28, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@vstpme vstpme added this pull request to the merge queue Mar 28, 2023
@vstpme vstpme changed the title Update apns payload with corrected critical field Update apns payload with corrected interruption-level field Mar 28, 2023
Merged via the queue into dev with commit 1c3c8e0 Mar 28, 2023
@vstpme vstpme deleted the apns-disable-critical branch March 28, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstpme vstpme vstpme approved these changes

@joeyorlando joeyorlando joeyorlando approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imtoori @vstpme @joeyorlando