Support notification priority in FCM relay #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
reviewed
Mar 27, 2023
| def fcm_relay_async(token, data, apns): | ||
| message = Message(token=token, data=data, apns=deserialize_apns(apns)) | ||
| def fcm_relay_async(token, data, apns, android=None): | ||
| message = _get_message_from_request_data(token, data, apns, android) |
There was a problem hiding this comment.
do we need the android argument here? this field should be available on the FCMDevice object fetched just a few lines below. See the type column in the fcm_django_fcmdevice table.
There was a problem hiding this comment.
The android field is needed to pass any Android related fields to FCM relay (e.g. priority). We don’t store any OSS device data in FCM relay, so the only way to get this data is to extract it from the request. Does it make sense?
There was a problem hiding this comment.
makes sense 👍 I sometimes get confused w/ the relay where certain data is being stored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds support for notification priority in FCM relay + add some tests on FCM relay.
Which issue(s) this PR fixes
Related to #1550 and #1612.
Checklist
No changelog update since notification priority is "Unreleased": https://github.com/grafana/oncall/blob/a2caeae3c7d15c81e72c70108e32617d68cf1a7b/CHANGELOG.md#unreleased