change escalation chains searching to allow for partial searching #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
commented
Mar 20, 2023
| @@ -46,7 +46,7 @@ class EscalationChainViewSet( | |||
| } | |||
|
|
|||
| filter_backends = [SearchFilter] | |||
| search_fields = ("^name",) | |||
| search_fields = ("name",) | |||
There was a problem hiding this comment.
main change (django-rest-framework docs)
bcee300 to
b89369b
Compare
teodosii
approved these changes
Mar 20, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
) # Which issue(s) this PR fixes Previously if you had an Escalation Chain named "Something Critical" and tried searching for "Critical", it would return no results. This was because the backend was using a "starts-with" search on the `name` attribute. This PR changes that to use "partial searching" + adds a few e2e test cases. ## Checklist - [x] Tests updated - [ ] Documentation added (N/A) - [x] `CHANGELOG.md` updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Previously if you had an Escalation Chain named "Something Critical" and tried searching for "Critical", it would return no results. This was because the backend was using a "starts-with" search on the
nameattribute.This PR changes that to use "partial searching" + adds a few e2e test cases.
Checklist
CHANGELOG.mdupdated