Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording when creating an integration #1572

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Conversation

callmehyde
Copy link
Contributor

Hello everyone 👋

This is my first PR to the OnCall repo so please let me know if I'm not doing something right. I'm also not sure if the items in the Checklist are for me to complete or someone else. If those are for me, please let me know and I'll be happy to do them (with some guidance as a first-timer)!

What this PR does

This PR is a really small suggestion to the wording in this file. I believe it will help improve the way this line of text is read by users.

Which issue(s) this PR fixes

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated

@callmehyde callmehyde requested a review from a team March 18, 2023 04:31
@CLAassistant
Copy link

CLAassistant commented Mar 18, 2023

CLA assistant check
All committers have signed the CLA.

@iskhakov iskhakov added the pr:no public docs Added to a PR that does not require public documentation updates label Mar 20, 2023
@iskhakov
Copy link
Contributor

Thank you for the contribution @callmehyde, all looks good to me. Could you please drop the following line to CHANGELOG.md

- Update wording when creating an integration ([1572](https://github.com/grafana/oncall/pull/1572))

@callmehyde
Copy link
Contributor Author

Thank you, @iskhakov! I updated CHANGELOG.md. Hopefully I did it right. 😄

Hello everyone 👋 

This is my first PR to the OnCall repo so please let me know if I'm not doing something right.

---

This PR is just a small update to the wording in the following screenshot.
@joeyorlando joeyorlando enabled auto-merge March 23, 2023 11:15
@joeyorlando joeyorlando added this pull request to the merge queue Mar 23, 2023
Merged via the queue into dev with commit 7e0f402 Mar 23, 2023
@joeyorlando joeyorlando deleted the callmehyde-patch-1 branch March 23, 2023 11:48
brojd pushed a commit that referenced this pull request Sep 18, 2024
Hello everyone 👋 

This is my first PR to the OnCall repo so please let me know if I'm not
doing something right. I'm also not sure if the items in the Checklist
are for me to complete or someone else. If those are for me, please let
me know and I'll be happy to do them (with some guidance as a
first-timer)!

# What this PR does
This PR is a really small suggestion to the wording in this file. I
believe it will help improve the way this line of text is read by users.

## Which issue(s) this PR fixes

## Checklist

- [ ] Tests updated
- [ ] Documentation added
- [ ] `CHANGELOG.md` updated

---------

Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants