-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wording when creating an integration #1572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskhakov
added
the
pr:no public docs
Added to a PR that does not require public documentation updates
label
Mar 20, 2023
Thank you for the contribution @callmehyde, all looks good to me. Could you please drop the following line to CHANGELOG.md
|
Thank you, @iskhakov! I updated CHANGELOG.md. Hopefully I did it right. 😄 |
joeyorlando
approved these changes
Mar 22, 2023
Hello everyone 👋 This is my first PR to the OnCall repo so please let me know if I'm not doing something right. --- This PR is just a small update to the wording in the following screenshot.
joeyorlando
force-pushed
the
callmehyde-patch-1
branch
from
March 23, 2023 11:08
416604b
to
5e27297
Compare
joeyorlando
approved these changes
Mar 23, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
Hello everyone 👋 This is my first PR to the OnCall repo so please let me know if I'm not doing something right. I'm also not sure if the items in the Checklist are for me to complete or someone else. If those are for me, please let me know and I'll be happy to do them (with some guidance as a first-timer)! # What this PR does This PR is a really small suggestion to the wording in this file. I believe it will help improve the way this line of text is read by users. ## Which issue(s) this PR fixes ## Checklist - [ ] Tests updated - [ ] Documentation added - [ ] `CHANGELOG.md` updated --------- Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com> Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone 👋
This is my first PR to the OnCall repo so please let me know if I'm not doing something right. I'm also not sure if the items in the Checklist are for me to complete or someone else. If those are for me, please let me know and I'll be happy to do them (with some guidance as a first-timer)!
What this PR does
This PR is a really small suggestion to the wording in this file. I believe it will help improve the way this line of text is read by users.
Which issue(s) this PR fixes
Checklist
CHANGELOG.md
updated