Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wording in some Slack messages which mention 'incident' instead of 'alert group' #1565

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

joeyorlando
Copy link
Contributor

What this PR does

image

Checklist

  • Tests updated (N/A)
  • Documentation added (N/A)
  • CHANGELOG.md updated

mention 'incident' instead of 'alert group'
@joeyorlando joeyorlando added the pr:no public docs Added to a PR that does not require public documentation updates label Mar 16, 2023
@joeyorlando joeyorlando requested a review from a team March 16, 2023 15:57

### Fixed

- Check for duplicated positions in terraform escalation policies create/update
- Fix resolution note rendering in Slack message threads where the Slack username was not
being properly rendered ([1561](https://github.com/grafana/oncall/pull/1561))
Copy link
Contributor Author

@joeyorlando joeyorlando Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line was moved from v1.1.40 to Unreleased. I accidentally added it to the wrong section in that PR.

@joeyorlando joeyorlando added this pull request to the merge queue Mar 16, 2023
Merged via the queue into dev with commit 515f62a Mar 16, 2023
@joeyorlando joeyorlando deleted the jorlando/update-slack-incident-wording branch March 16, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants