Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert group filter by escalation chain #1535

Merged
merged 8 commits into from
Mar 14, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Mar 13, 2023

What this PR does

Adds a new filter on alert groups page that allows to filter alert groups by escalation chain.

Screenshot 2023-03-13 at 22 42 00

Which issue(s) this PR fixes

This should be useful on it's own as it's giving more filtering capabilities, but it also could be useful for #1300, if PD rulesets are migrated to a single integration with multiple escalation chains.

Checklist

  • Tests updated
  • CHANGELOG.md updated

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Mar 13, 2023
@vstpme vstpme marked this pull request as ready for review March 14, 2023 10:16
@vstpme vstpme requested review from a team March 14, 2023 10:16
@vstpme vstpme enabled auto-merge March 14, 2023 13:10
@vstpme vstpme added this pull request to the merge queue Mar 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2023
@vstpme
Copy link
Member Author

vstpme commented Mar 14, 2023

Hmm, the integration test introduced in this PR seems to be flaky, I'll remove it from this PR and try to fix it in a separate PR.

@vstpme vstpme added this pull request to the merge queue Mar 14, 2023
Merged via the queue into dev with commit 61b7c2e Mar 14, 2023
@vstpme vstpme deleted the vadimkerr/alert-groups-filter-escalation-chain branch March 14, 2023 14:54
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does
Adds a new filter on alert groups page that allows to filter alert
groups by escalation chain.

<img width="1204" alt="Screenshot 2023-03-13 at 22 42 00"
src="https://user-images.githubusercontent.com/20116910/224848730-ef753856-a050-4acb-ba36-498d2bca2b4f.png">


## Which issue(s) this PR fixes
This should be useful on it's own as it's giving more filtering
capabilities, but it also could be useful for
#1300, if PD rulesets are
migrated to a single integration with multiple escalation chains.

## Checklist

- [x] Tests updated
- [x] `CHANGELOG.md` updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants