Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make current day default for override creation modal #1515

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Mar 9, 2023

What this PR does

Makes current day default for override creation modal + adds a simple integration test

Which issue(s) this PR fixes

https://github.com/grafana/oncall-private/issues/1674

Checklist

  • Tests updated
  • CHANGELOG.md updated

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Mar 9, 2023
@vstpme vstpme marked this pull request as ready for review March 9, 2023 12:58
@vstpme vstpme requested a review from a team March 9, 2023 12:58
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 for the added integration test

@vstpme vstpme added this pull request to the merge queue Mar 9, 2023
Merged via the queue into dev with commit e7652ab Mar 9, 2023
@vstpme vstpme deleted the vadimkerr/default-override-today branch March 9, 2023 13:30
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does
Makes current day default for override creation modal + adds a simple
integration test

## Which issue(s) this PR fixes
grafana/oncall-private#1674

## Checklist

- [x] Tests updated
- [x] `CHANGELOG.md` updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants