Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pagination issue when searching schedules #1437

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Fix pagination issue when searching schedules #1437

merged 2 commits into from
Mar 1, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Mar 1, 2023 •
edited
Loading

What this PR does

Fixes a bug with inconsistent schedule count when searching by name.

Example (2 schedules returned, but count is incorrectly set to 12):
image

Checklist

  • Tests updated
  • CHANGELOG.md updated

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Mar 1, 2023
@vstpme vstpme requested a review from a team March 1, 2023 16:20
@vstpme vstpme added this pull request to the merge queue Mar 1, 2023
Merged via the queue into dev with commit 8170ca4 Mar 1, 2023
@vstpme vstpme deleted the vadimkerr/fix-schedule-pagination-search branch March 1, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mderynck mderynck mderynck approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstpme @mderynck