fix for #1273, added component for showing permission restricted acce… #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss, removed unused Test code
maskin25
approved these changes
Mar 2, 2023
| title?: string; | ||
| } | ||
|
|
||
| export const WithPermissionControlDisplay = observer((props: WithPermissionControlDisplayProps) => { |
There was a problem hiding this comment.
do you need observer decorator here?
There was a problem hiding this comment.
No, not really. I'll remove it
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
#1422) # What this PR does - Removed unused code - Added another component for displaying Error Messages based on permissions access (so that we do not duplicate this code everywhere it's needed) - Fix for #1273 ## Which issue(s) this PR fixes - #1273 ## Checklist - [ ] Tests updated - [ ] Documentation added - [ ] `CHANGELOG.md` updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes
Checklist
CHANGELOG.mdupdated