Use Tilt for local development #1396

bcotton · 2023-02-23T14:25:23Z

What this PR does

PR adds Tilt for local development

Which issue(s) this PR fixes

Checklist

Tests updated
Documentation added
CHANGELOG.md updated

CLAassistant · 2023-02-23T14:27:12Z

All committers have signed the CLA.

engine/Dockerfile

debian package

joeyorlando · 2023-02-24T15:46:58Z

engine/Dockerfile

@@ -28,7 +28,8 @@ RUN mkdir -p /tmp/silk_profiles;
 RUN chown -R 1000:2000 /tmp/silk_profiles

 FROM base AS dev
-RUN apt-get install -y sqlite3 default-mysql-client postgresql-client


this change should be reverted prior to merging. This is a temporary workaround to this issue when building the engine docker image:

→ E: Failed to fetch http://deb.debian.org/debian-security/pool/updates/main/m/mariadb-10.3/mariadb-client-core-10.3_10.3.36-0+deb10u2_arm64.deb 404 Not Found [IP: 199.232.150.132 80] → E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing? ERROR IN: [dev 1/1] RUN apt-get install -y sqlite3 default-mysql-client [redacted secret helm-testing-postgresql:postgres-password]ql-client Build Failed: ImageBuild: executor failed running [/bin/sh -c apt-get install -y sqlite3 default-mysql-client [redacted secret helm-testing-postgresql:postgres-password]ql-client]: exit code: 100

generated by tilt

joeyorlando · 2023-02-24T16:16:41Z

.gitignore

@@ -6,3 +6,6 @@ venv
 .idea
 .DS_Store
 .env
+
+yarn.lock
+node_modules


adding these as tilt up seems to generate them

github-actions · 2023-06-10T01:59:44Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions · 2023-07-14T02:08:11Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions · 2023-08-14T01:44:46Z

This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

iskhakov · 2023-08-25T05:09:51Z

helm/README.md

+   If you happen to `helm uninstall helm-testing` be sure to delete all the Persistent Volume Claims, as Postgres stores
+   the auto-generated password on disk, and the next `helm install` will fail.
+
+   ```bash
+   kubectl delete pvc --all
+   kubectl delete pv --all
+   ```
+
+   This, of course, will delete all the PVs and PVCs also :-)


Added hardcoded passwords for local development to avoid deletions (see here)

joeyorlando · 2023-08-25T07:22:32Z

Tiltfile

+  set=extra_helm_values(),
+  # The values file to substitute into the chart.
+  values=['./helm/simple.yml',
+          './helm/values-arm64.yml',


./helm/values-arm64.yml no longer exists as all of our Chart dependencies now have multi-arch support

bcotton · 2023-08-25T14:45:58Z

Tiltfile

@@ -15,7 +20,25 @@ yaml = helm(

 k8s_yaml(yaml)

-k8s_resource(workload='grafana', port_forwards="3000:3000", resource_deps=['mariadb', 'engine', 'oncall-ui'], labels=['Grafana'])
+# Generate and load the grafana deploy yaml
+k8s_yaml(local("cat ./dev/cm-grafana-oncall-app-provisioning.yaml"))


This file is missing

Makefile

joeyorlando · 2023-09-04T12:59:06Z

Makefile


-See https://github.com/grafana/oncall/pull/2751 for instructions on how to use the helm/k8s commands.
+See https://github.com/grafana/oncall/pull/2751 for instructions on how to use tilt helm/k8s commands.


maybe remove this comment or point it to this PR

engine/Dockerfile

This reverts commit b93143f.

This reverts commit 2515375.

…ll plugin""" This reverts commit 6713897.

Co-authored-by: Joey Orlando <joey.orlando@grafana.com>

# What this PR does PR adds Tilt for local development ## Which issue(s) this PR fixes ## Checklist - [ ] Tests updated - [ ] Documentation added - [ ] `CHANGELOG.md` updated --------- Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com> Co-authored-by: Ildar Iskhakov <Ildar.iskhakov@grafana.com> Co-authored-by: Michael Derynck <michael.derynck@grafana.com> Co-authored-by: Joey Orlando <joey.orlando@grafana.com>

starting to get tilt running

0095a41

bcotton requested a review from a team February 23, 2023 14:25

changed needed for tilt

1ba203b

joeyorlando reviewed Feb 24, 2023

View reviewed changes

engine/Dockerfile Outdated Show resolved Hide resolved

bcotton and others added 2 commits February 24, 2023 08:44

Set the url for the backend for all cases

92d7ee9

temporary fix for missing default-mysql-client

45e5375

debian package

joeyorlando reviewed Feb 24, 2023

View reviewed changes

joeyorlando added 2 commits February 24, 2023 17:05

fix database migrations not running

12c3841

ignore node_modules and yarn.lock that're

62c3c73

generated by tilt

joeyorlando reviewed Feb 24, 2023

View reviewed changes

mderynck force-pushed the dev branch from c50f4f0 to cdb62f2 Compare April 25, 2023 22:40

github-actions bot added the Stale label Jun 10, 2023

Matvey-Kuk removed the Stale label Jun 13, 2023

github-actions bot added the pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action label Jul 14, 2023

github-actions bot closed this Aug 14, 2023

iskhakov reopened this Aug 21, 2023

Merge branch 'dev' into tiltify

bfb8a44

github-actions bot removed the pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action label Aug 22, 2023

iskhakov reviewed Aug 25, 2023

View reviewed changes

Merge branch 'dev' into tiltify

659d3b3

joeyorlando reviewed Aug 25, 2023

View reviewed changes

iskhakov added 2 commits August 25, 2023 16:59

Update tilt dev env

faa10c5

Use separate grafana from tilt extensions

e6aedf3

bcotton commented Aug 25, 2023

View reviewed changes

Build the grafana-plugin in the background using docker compose

f4fe085

bcotton requested a review from a team August 28, 2023 03:33

mderynck and others added 5 commits September 1, 2023 13:34

Add checks for API_KEY and ONCALL_TOKEN

91ed44e

Use grafana extension from github

60af7a9

Merge branch 'dev' into tiltify

f087035

Clean up

7741fb8

Update Tiltfile

6486eac

joeyorlando reviewed Sep 4, 2023

View reviewed changes

Makefile Outdated Show resolved Hide resolved

joeyorlando reviewed Sep 4, 2023

View reviewed changes

engine/Dockerfile Outdated Show resolved Hide resolved

iskhakov and others added 11 commits September 4, 2023 22:48

Revert "added a post-build hook to configure the oncall plugin"

2515375

This reverts commit b93143f.

Optimise image build time for arm64 architectures

a9ceae2

Revert "Revert "added a post-build hook to configure the oncall plugin""

6713897

This reverts commit 2515375.

Revert "Revert "Revert "added a post-build hook to configure the onca…

795c350

…ll plugin""" This reverts commit 6713897.

Install and initialise plugin automatically

f3202ff

Add docs

92459f8

Update engine/Dockerfile

83b4404

Co-authored-by: Joey Orlando <joey.orlando@grafana.com>

Update Makefile

79d0e3d

Co-authored-by: Joey Orlando <joey.orlando@grafana.com>

Update Makefile

200f6f0

Clean up, fix issue with 502 errors

ad75f98

Update CHANGELOG.md

88f9009

iskhakov changed the title ~~WIP - starting to get tilt running~~ Use Tilt for local development Sep 7, 2023

iskhakov added the pr:no public docs Added to a PR that does not require public documentation updates label Sep 7, 2023

Merge branch 'dev' into tiltify

f4d7b86

iskhakov enabled auto-merge September 7, 2023 05:00

iskhakov added 2 commits September 7, 2023 15:04

Fix tests

dbcc052

Fix unittests

d133f42

iskhakov approved these changes Sep 7, 2023

View reviewed changes

iskhakov disabled auto-merge September 7, 2023 11:38

iskhakov merged commit 6c8344a into dev Sep 7, 2023

iskhakov deleted the tiltify branch September 7, 2023 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Tilt for local development #1396

Use Tilt for local development #1396

bcotton commented Feb 23, 2023 •

edited by iskhakov

Loading

CLAassistant commented Feb 23, 2023 •

edited

Loading

joeyorlando Feb 24, 2023

joeyorlando Feb 24, 2023

github-actions bot commented Jun 10, 2023

github-actions bot commented Jul 14, 2023

github-actions bot commented Aug 14, 2023

iskhakov Aug 25, 2023 •

edited

Loading

joeyorlando Aug 25, 2023

bcotton Aug 25, 2023

joeyorlando Sep 4, 2023


		See https://github.com/grafana/oncall/pull/2751 for instructions on how to use the helm/k8s commands.
		See https://github.com/grafana/oncall/pull/2751 for instructions on how to use tilt helm/k8s commands.

Use Tilt for local development #1396

Use Tilt for local development #1396

Conversation

bcotton commented Feb 23, 2023 • edited by iskhakov Loading

What this PR does

Which issue(s) this PR fixes

Checklist

CLAassistant commented Feb 23, 2023 • edited Loading

joeyorlando Feb 24, 2023

Choose a reason for hiding this comment

joeyorlando Feb 24, 2023

Choose a reason for hiding this comment

github-actions bot commented Jun 10, 2023

github-actions bot commented Jul 14, 2023

github-actions bot commented Aug 14, 2023

iskhakov Aug 25, 2023 • edited Loading

Choose a reason for hiding this comment

joeyorlando Aug 25, 2023

Choose a reason for hiding this comment

bcotton Aug 25, 2023

Choose a reason for hiding this comment

joeyorlando Sep 4, 2023

Choose a reason for hiding this comment

bcotton commented Feb 23, 2023 •

edited by iskhakov

Loading

CLAassistant commented Feb 23, 2023 •

edited

Loading

iskhakov Aug 25, 2023 •

edited

Loading