Add option to use helm hook for migration job #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskhakov
approved these changes
Mar 2, 2023
auto-merge was automatically disabled
March 2, 2023 12:21
Head branch was pushed to by a user without write access
|
I am not sure how to get rid of the "Verify public documentation" check. I think there is nothing to update, but I cannot add the "no public docs" labels. |
138c6a0 to
072c4d0
Compare
|
@Mattes83 thank you for the contribution, it will be merged shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds the option to use helm hooks for the database migration.
Which issue(s) this PR fixes
Currently oncall always shows as out-of-sync in argo-cd because the name changes on each hard refresh.
When using a helm hook the job is executed on sync but does not show as out-of-sync
Checklist
CHANGELOG.mdupdated