-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jinja2 based routes #1319
Merged
Merged
Jinja2 based routes #1319
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7947941
Add jinja2 based routing
iskhakov 1833fcd
Add migrations
iskhakov 2c71748
Try using enum
iskhakov 5730e4c
Merge branch 'dev' into iskhakov/jinja2-routes
iskhakov 9448fa5
Improve design
iskhakov 478f72b
Add design improvements
iskhakov 048a701
Use one model field to store both jinja2 and regex terms
iskhakov 0d48c01
Fontend cleanup
iskhakov 2630778
Fix button name
iskhakov a109b0a
Refactor ChannelFilter.str_for_clients function
iskhakov 7707f3d
Fixes
iskhakov 2cc3b46
Add docs
iskhakov 5ec760b
Add default value on the database level to prevent release crash
iskhakov 351277c
Add validation
iskhakov 401b1b1
Add better comment
iskhakov f77b4bc
Merge branch 'dev' into iskhakov/jinja2-routes
iskhakov d430a16
Add tests
iskhakov 4ee0652
Add changes to api and docs
iskhakov bc2e3a7
Edit test_routes.py
iskhakov 17675e3
Edit test_routes.py
iskhakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add default value on the database level to prevent release crash
- Loading branch information
commit 5ec760b1fd5d59d3dd9c1f449742bf7e9c38ca4e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is possible with RunSQL to insert default values, but we'll need to do that manually for each database. django_add_default_value does that for us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get that idea. Why we need AddDefaultValue, when we have default=0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left the better comment in the code
for more details I recommend to read this article