Cache web template rendered fields for alert and alertgroup endpoints #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
overall looks good. Wondering if it'd be possible to combine AlertFieldsCacheSerializerMixin and AlertGroupFieldsCacheSerializerMixin as there's quite a bit of overlap in their logic (or maybe extract out most of the logic into a parent class that they both inherit)?
|
The only difference is the cache invalidation condition, but combining the rest into a single function just made the code less clean. Decided to optimise it next time if we start using this approach elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds same approach as introduced here to all alert and alertgroup endpoints
Which issue(s) this PR fixes
Checklist
CHANGELOG.mdupdated