823 direct paging users #1215
Merged
823 direct paging users #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodosii
reviewed
Feb 7, 2023
teodosii
reviewed
Feb 7, 2023
teodosii
reviewed
Feb 7, 2023
grafana-plugin/src/components/SearchInput/SearchInput.module.css
Outdated
Show resolved
Hide resolved
teodosii
reviewed
Feb 7, 2023
| export function useOnClickOutside(ref, handler) { | ||
| useEffect(() => { | ||
| const listener = (event) => { | ||
| if (!ref.current || ref.current.contains(event.target)) { |
There was a problem hiding this comment.
if(ref.current?.contains(event.target)) {}shorthand 🚀
There was a problem hiding this comment.
your expression doesn't do the same
There was a problem hiding this comment.
Ohh, my bad. I read it as && instead...
teodosii
reviewed
Feb 7, 2023
teodosii
reviewed
Feb 7, 2023
teodosii
reviewed
Feb 7, 2023
teodosii
reviewed
Feb 7, 2023
teodosii
approved these changes
Feb 7, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does Adds direct user paging ## Which issue(s) this PR fixes #823 ## Checklist - [ ] Tests updated - [ ] Documentation added (documentation will be added later) - [x] `CHANGELOG.md` updated --------- Co-authored-by: Maxim <maxim.mordasov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes
Checklist
CHANGELOG.mdupdated