Refactor plugin sync #1200
Refactor plugin sync #1200
Conversation
| organization.api_token_status = Organization.API_TOKEN_STATUS_PENDING | ||
|
|
||
| organization.save(update_fields=["api_token_status"]) | ||
| try: |
There was a problem hiding this comment.
Could you please add comments here? I didn't catch the meaning of that check and why we setting API_TOKEN_STATUS_PENDING if we failed to get user from grafana context.
There was a problem hiding this comment.
For all the other cases (user does not exist, organisation token "not ok", etc) process remains same - plugin will show "Initialising plugin..." until the background task in successfully completed
There was a problem hiding this comment.
Yep, but what is the case you are checking here and what is the expected behaviour? I mean, in which case we are unable to get user from grafana context?
There was a problem hiding this comment.
btw, cleaned up a little and added pr description
you were too fast:)
There was a problem hiding this comment.
fixed is_installed part, thanks
Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
|
Fixes part of this issue |
What this PR does
This PR adds a shortcut in the plugin synchronisation process, so the existing users will be able login without waiting for the sync task. Every request still starts the background synchronisation task, to be able to propagate the organisation changes faster than periodic task. It means that we don't necessarily need "force reload" button in the interface.
For all the other cases (user does not exist, organisation token "not ok", etc) process remains same - plugin will show "Initialising plugin..." until the background task in successfully completed
Which issue(s) this PR fixes
Checklist
CHANGELOG.mdupdated