Simplify and speed up slack rendering #1105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR simplify and speed up slack rendering.
For alert group with large amount of alerts query
self.alert_group.alerts.filter(is_resolve_signal=False)
took a several seconds to execute, since is_resolve_signalnot indexed. On the other hand, that query makes no sence, because anyway we using all alerts, when rendering their count in slack:So, I decided to remove filtering by is_resolve_signal in that case and leave only one
alert_group.alerts.count()
query.Also, I checked that we have no any organizations which installed slack not via granular permissions and removed this check, which produced 4 SELECTs. For OSS slack we provide app manifest, so
self.alert_group.channel.organization.slack_team_identity.installed_via_granular_permissions
check can be safely removed.