Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin didn't rewrite url path resources #672

Closed
wounkun opened this issue Oct 19, 2022 · 1 comment · Fixed by #1348
Closed

plugin didn't rewrite url path resources #672

wounkun opened this issue Oct 19, 2022 · 1 comment · Fixed by #1348
Assignees
@teodosii
Labels
bug Something isn't working involved:Frontend

Comments

@wounkun
Copy link

wounkun commented Oct 19, 2022

image

I got a problem on grafana that reversed by nginx which has different root url, example: %(protocol)s://%(domain)s/grafana/. Plugin page opening CSS-file with incorrect url path:

https://host/grafana/public/plugins/grafana-oncall-app/img/grafanaGlobalStyles.css
@mderynck mderynck added the bug Something isn't working label Oct 19, 2022
@maskin25 maskin25 assigned maskin25 and teodosii and unassigned maskin25 Feb 8, 2023
@teodosii teodosii mentioned this issue Feb 20, 2023
Merged
3 tasks
@teodosii
Copy link
Member

Opened a PR here #1348

This will most likely fix this issue as now we will no longer import by path, instead append the whole css to the head element.

teodosii added a commit that referenced this issue Feb 24, 2023
@teodosii
Append grafana styles to head instead of referencing the wrong path (#…
12a04db 
…1348)

# What this PR does

Fixed #672 so that we import the css as a whole and add it as a `style`
element, instead of relying on path location which can differ if url is
rewritten.

## Which issue(s) this PR fixes

#672 

## Checklist

- [ ] Tests updated
- [ ] Documentation added
- [ ] `CHANGELOG.md` updated
brojd pushed a commit that referenced this issue Sep 18, 2024
@teodosii
Append grafana styles to head instead of referencing the wrong path (#…
f417eaf 
…1348)

# What this PR does

Fixed #672 so that we import the css as a whole and add it as a `style`
element, instead of relying on path location which can differ if url is
rewritten.

## Which issue(s) this PR fixes

#672 

## Checklist

- [ ] Tests updated
- [ ] Documentation added
- [ ] `CHANGELOG.md` updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teodosii teodosii

Labels
bug Something isn't working involved:Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Append grafana styles to head instead of referencing the wrong path grafana/oncall
4 participants
@maskin25 @mderynck @wounkun @teodosii