Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack shift change notifications don't consider shift swaps #3096

Closed
charleskorn opened this issue Oct 1, 2023 · 1 comment
Closed

Slack shift change notifications don't consider shift swaps #3096

charleskorn opened this issue Oct 1, 2023 · 1 comment
Assignees
Labels
bug Something isn't working part:chatops

Comments

@charleskorn
Copy link

charleskorn commented Oct 1, 2023

What went wrong?

What happened:
My regular on-call shift time based on our rotations is 13:00 - 01:00.

I'd arranged a shift swap for the last few hours of this shift, from 21:00 - 01:00.

The shift change notification in our Slack channel reported my shift as running from 13:00 - 01:00 (ie. ignored the shift swap), and reported my colleague's shift as running from 21:00 - 01:00.

Screenshot 2023-10-02 at 9 57 34 am

What did you expect to happen:
My shift was reported as ending at 21:00, when the swap began.

How do we reproduce it?

  1. Create a schedule and rotation
  2. Add yourself to the rotation
  3. Arrange a shift swap for the last portion of your regularly scheduled shift
  4. Wait for the shift change notification in Slack

Grafana OnCall Version

r236-v1.3.40

Product Area

Chatops

Grafana OnCall Platform?

I use Grafana Cloud

User's Browser?

No response

Anything else to add?

No response

@matiasb
Copy link
Contributor

matiasb commented Oct 4, 2023

This should have now been fixed with the referenced PR.

@matiasb matiasb closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working part:chatops
Projects
None yet
Development

No branches or pull requests

2 participants