Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring new Jinja editor to webhooks #2344

Closed
Matvey-Kuk opened this issue Jun 26, 2023 · 2 comments
Closed

Bring new Jinja editor to webhooks #2344

Matvey-Kuk opened this issue Jun 26, 2023 · 2 comments
Assignees
@maskin25 @teodosii @raphael-batte
Labels
feature request New feature or request part:webhooks

Comments

@Matvey-Kuk
Copy link
Contributor

Matvey-Kuk commented Jun 26, 2023 •
edited
Loading

In v1.3.0 we rolled out new Jinja editor. We want to use it for editing of Jinja in webhooks as well.

Also we need to build webhook cheatsheet and variable hints.
@Matvey-Kuk Matvey-Kuk added feature request New feature or request part:webhooks labels Jun 26, 2023
@github-actions
Copy link
Contributor

The current version of Grafana OnCall, at the time this issue was opened, is v1.3.0. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you 😄!

@raphael-batte raphael-batte self-assigned this Jun 28, 2023
@teodosii teodosii self-assigned this Jul 5, 2023
@maskin25 maskin25 mentioned this issue Jul 5, 2023
Closed
3 tasks
@teodosii
Copy link
Member

teodosii commented Jul 7, 2023 •
edited
Loading

Quick update on this ticket:

  • @maskin25 added the changes need for the GForm to support editing monaco fields
  • I replicated the template editor built for Integrations and added the required changes to open the editor & update the form accordingly. Once we have a working endpoint for fetching these new alert groups for webhooks, we'll need to add the fetch for the given alert groups and pass the webhook id to the preview endpoint to visualize the template result. (right now that seems to be dependent on a channelId instead)

@maskin25 maskin25 mentioned this issue Jul 11, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 11, 2023
@teodosii @mderynck
Rares/add template editor to webhooks (#2455)
5ebf437 
# What this PR does

Bring new Jinja editor to webhooks

## Which issue(s) this PR fixes

#2344

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)

---------

Co-authored-by: Maxim <maxim.mordasov@grafana.com>
Co-authored-by: Michael Derynck <michael.derynck@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maskin25 maskin25

@teodosii teodosii

@raphael-batte raphael-batte

Labels
feature request New feature or request part:webhooks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@maskin25 @Matvey-Kuk @Ukochka @teodosii @raphael-batte