Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting PHONE_PROVIDER to empty value breaks OSS OnCall #2323

Closed
vstpme opened this issue Jun 23, 2023 · 0 comments
Closed

Setting PHONE_PROVIDER to empty value breaks OSS OnCall #2323

vstpme opened this issue Jun 23, 2023 · 0 comments
Labels
bug Something isn't working part:helm/kubernetes/docker

Comments

@vstpme
Copy link
Member

vstpme commented Jun 23, 2023

What went wrong?

What happened:

  • I've set the PHONE_PROVIDER live setting to be empty
  • All pages stopped loading after that

What did you expect to happen:

  • I expect that changing PHONE_PROVIDER live setting won't break all plugin pages

How do we reproduce it?

  1. Open Grafana OnCall plugin, go to Settings -> Env Variables
  2. Find PHONE_PROVIDER setting and edit it to be empty
  3. Refresh the page, the page goes blank. The same happens for all pages.
Screenshot 2023-06-23 at 14 21 01

Grafana OnCall Version

v1.2.45

Product Area

Helm

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response
@vstpme vstpme added bug Something isn't working part:helm/kubernetes/docker labels Jun 23, 2023
@eugenefeel eugenefeel mentioned this issue Jul 13, 2023
Open
@sreway sreway mentioned this issue Jul 13, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 17, 2023
@sreway @Konstantinov-Innokentii @joeyorlando
set default phone provider (#2523)
8644883 
# What this PR does

Sets a default value for the PHONE_PROVIDER setting and replaces the
value of PHONE_PROVIDER with this default value if it is not valid.

## Which issue(s) this PR fixes

- [#2520](#2520)
- [#2323](#2323)

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)

---------

Co-authored-by: Innokentii Konstantinov <innokenty.konstantinov@grafana.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
@vstpme vstpme closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working part:helm/kubernetes/docker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstpme