Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning popup while editing smth in the drawer and clicking outside #1493

Closed
Ukochka opened this issue Mar 8, 2023 · 1 comment
Closed

Add warning popup while editing smth in the drawer and clicking outside #1493

Ukochka opened this issue Mar 8, 2023 · 1 comment
Assignees
@Ukochka
Labels
feature request New feature or request involved:Frontend

Comments

@Ukochka
Copy link
Contributor

Ukochka commented Mar 8, 2023

While creating/editing Schedule/Webhook/Template/etc we can click outside of the drawer and the drawer will be closed and all data we were filling in will be lost
@Ukochka Ukochka added feature request New feature or request involved:Frontend labels Mar 8, 2023
@Ukochka Ukochka self-assigned this Mar 8, 2023
@Ukochka
Copy link
Contributor Author

Ukochka commented Mar 22, 2023

After short conversation with @raphael-batte we agreed that it is better to not allow to close the Drawer by clicking outside. We have button for closing it. So instead of showing the warning popup we will change the behaviour of closing it

@Ukochka Ukochka mentioned this issue Mar 23, 2023
Merged
brojd pushed a commit that referenced this issue Sep 18, 2024
@Ukochka
Closing drawers by clicking outside was changed (#1608)
f095cbe 
# What this PR does
Closing drawers by clicking outside was changed to closing by clicking
on buttons

## Which issue(s) this PR fixes
#1493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ukochka Ukochka

Labels
feature request New feature or request involved:Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ukochka