-
Notifications
You must be signed in to change notification settings - Fork 301
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add option for sidecar containers in helm chart (#2650)
# What this PR does Adds support for defining extra containers which run as sidecar alongside the celery and engine containers ## Which issue(s) this PR fixes ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
- Loading branch information
Showing
8 changed files
with
117 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
suite: test extra containers for celery pod | ||
templates: | ||
- celery/deployment-celery.yaml | ||
release: | ||
name: oncall | ||
tests: | ||
- it: celery.extraContainers="" -> should not create additional containers | ||
set: | ||
celery.extraContainers: "" | ||
asserts: | ||
- lengthEqual: | ||
path: spec.template.spec.containers | ||
count : 1 | ||
|
||
- it: celery.extraContainers -> should add sidecar containers | ||
set: | ||
celery.extraContainers: | | ||
- name: cloud-sql-proxy | ||
image: gcr.io/cloud-sql-connectors/cloud-sql-proxy | ||
asserts: | ||
- contains: | ||
path: spec.template.spec.containers | ||
content: | ||
name: cloud-sql-proxy | ||
image: gcr.io/cloud-sql-connectors/cloud-sql-proxy |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
suite: test extra containers for engine pod | ||
templates: | ||
- engine/deployment.yaml | ||
release: | ||
name: oncall | ||
tests: | ||
- it: engine.extraContainers="" -> should not create additional containers | ||
set: | ||
engine.extraContainers: "" | ||
asserts: | ||
- lengthEqual: | ||
path: spec.template.spec.containers | ||
count : 1 | ||
|
||
- it: engine.extraContainers -> should add sidecar containers | ||
set: | ||
engine.extraContainers: | | ||
- name: cloud-sql-proxy | ||
image: gcr.io/cloud-sql-connectors/cloud-sql-proxy | ||
asserts: | ||
- contains: | ||
path: spec.template.spec.containers | ||
content: | ||
name: cloud-sql-proxy | ||
image: gcr.io/cloud-sql-connectors/cloud-sql-proxy |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
suite: test migrate extra containers | ||
templates: | ||
- engine/job-migrate.yaml | ||
release: | ||
name: oncall | ||
tests: | ||
- it: migrate.extraContainers="" -> should not create additional containers | ||
set: | ||
migrate.extraContainers: "" | ||
asserts: | ||
- lengthEqual: | ||
path: spec.template.spec.containers | ||
count : 1 | ||
|
||
- it: migrate.extraContainers -> should add sidecar containers | ||
set: | ||
migrate.extraContainers: | | ||
- name: cloud-sql-proxy | ||
image: gcr.io/cloud-sql-connectors/cloud-sql-proxy | ||
asserts: | ||
- contains: | ||
path: spec.template.spec.containers | ||
content: | ||
name: cloud-sql-proxy | ||
image: gcr.io/cloud-sql-connectors/cloud-sql-proxy |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters