changelog

fixed routes
grafana · Mar 30, 2023 · 4f2fc85 · 4f2fc85
1 parent 4b1f495
commit 4f2fc85
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+
+### Changes
+
+- Renamed routes from /incidents to /alert-groups ([#1678](https://github.com/grafana/oncall/pull/1678))
+
 ## v1.2.6 (2023-03-30)
 
 ### Fixed

diff --git a/grafana-plugin/src/pages/index.tsx b/grafana-plugin/src/pages/index.tsx
@@ -34,19 +34,6 @@ export const pages: { [id: string]: PageDefinition } = [
     path: getPath('alert-groups'),
     action: UserActions.AlertGroupsRead,
   },
-  {
-    icon: 'bell',
-    id: 'alert-group',
-    text: '',
-    hideFromTabs: true,
-    hideFromBreadcrumbs: true,
-    parentItem: {
-      text: 'Alert Group',
-      url: `${PLUGIN_ROOT}/alert-groups`,
-    },
-    path: getPath('alert-groups'),
-    action: UserActions.AlertGroupsRead,
-  },
   {
     icon: 'users-alt',
     id: 'users',

diff --git a/grafana-plugin/src/plugin/GrafanaPluginRootPage.tsx b/grafana-plugin/src/plugin/GrafanaPluginRootPage.tsx
@@ -184,6 +184,7 @@ export const Root = observer((props: AppRootProps) => {
               <CloudPage />
             </Route>
 
+            {/* Backwards compatibility redirect routes */}
             <Route
               path={getRoutesForPage('incident')}
               exact

diff --git a/grafana-plugin/src/utils/url.ts b/grafana-plugin/src/utils/url.ts
@@ -22,7 +22,7 @@ export function getPathFromQueryParams(query: ParsedQuery<string>) {
     path += `/${normalizedQuery.page}`;
 
     if (normalizedQuery.id) {
-      if (normalizedQuery.page === 'alert-group' || normalizedQuery.page === 'schedule') {
+      if (normalizedQuery.page === 'incident' || normalizedQuery.page === 'schedule') {
         path += 's';
       }