Skip to content

Commit

Permalink
Fix wording for cloud notifications (#1458)
Browse files Browse the repository at this point in the history
# What this PR does
Fix message on Phone Verification tab.
  • Loading branch information
Konstantinov-Innokentii authored Mar 6, 2023
1 parent 4b91203 commit 19f1491
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import PluginLink from 'components/PluginLink/PluginLink';
import Text from 'components/Text/Text';
import { WithPermissionControlDisplay } from 'containers/WithPermissionControl/WithPermissionControlDisplay';
import { User } from 'models/user/user.types';
import { AppFeature } from 'state/features';
import { WithStoreProps } from 'state/types';
import { useStore } from 'state/useStore';
import { withMobXProviderContext } from 'state/withStore';
Expand Down Expand Up @@ -50,21 +49,14 @@ const CloudPhoneSettings = observer((props: CloudPhoneSettingsProps) => {
const UserCloudStatus = () => {
switch (userStatus) {
case 0:
if (store.hasFeature(AppFeature.CloudNotifications)) {
return (
<VerticalGroup spacing="lg">
<Text>Your account successfully matched, but Cloud is not connected. </Text>
<PluginLink query={{ page: 'cloud' }}>
<Button variant="secondary" icon="external-link-alt">
Open Grafana Cloud page
</Button>
</PluginLink>
</VerticalGroup>
);
}
return (
<VerticalGroup spacing="lg">
<Text>Grafana Cloud is not synced</Text>
<Text>Cloud notifications enabled, but Grafana Cloud instance is not connected.</Text>
<PluginLink query={{ page: 'cloud' }}>
<Button variant="secondary" icon="external-link-alt">
Open Grafana Cloud page
</Button>
</PluginLink>
</VerticalGroup>
);
case 1:
Expand Down
4 changes: 3 additions & 1 deletion grafana-plugin/src/pages/settings/tabs/Cloud/CloudPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,9 @@ const CloudPage = observer((props: CloudPageProps) => {
<Icon name="bell" className={cx('block-icon')} size="lg" /> SMS and phone call notifications
</Text.Title>

<Text type="secondary">Users matched between OSS and Cloud OnCall currently unavailable.</Text>
<Text type="secondary">
Connecting to Cloud OnCall enables sending SMS and phone call notifications using the cloud Grafana OnCall.
</Text>
</VerticalGroup>
</Block>
{store.hasFeature(AppFeature.MobileApp) && (
Expand Down

0 comments on commit 19f1491

Please sign in to comment.