Remote read first class: implement blocking queries #8353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
524679b to
3d19b2e
Compare
Make place for a remote read roundtripper that would wrap limits and blocking checks. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
3d19b2e to
f820df2
Compare
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Return more details on the API. Sync the error and log messages for easier correlation of logs and also blocked_queries configuration. Update docs and changelog. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2 tasks
|
Superseded by #8372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Propose structure for implementing query blocking and limits enforcement for remote read
Which issue(s) this PR fixes or relates to
Related to https://github.com/grafana/pir-actions/issues/10 (internal)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.