-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mixin: remove mention of pod name is some alert messages #8168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex5517
changed the title
add per_instance_label to aggregation since it is used in alert template
[mixin] add per_instance_label to aggregation since it is used in alert template
May 22, 2024
alex5517
changed the title
[mixin] add per_instance_label to aggregation since it is used in alert template
mixin: add per_instance_label to aggregation since it is used in alert template
May 23, 2024
@dimitarvdimitrov, Thanks i removed the per_instance_label and updated the message so it no longer included. |
dimitarvdimitrov
changed the title
mixin: add per_instance_label to aggregation since it is used in alert template
mixin: remove mention of pod name is some alert messages
Jul 4, 2024
dimitarvdimitrov
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alex5517! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
I found a few places where {{ $labels.pod }} is used in message, but the query removes it.
Which issue(s) this PR fixes or relates to
N/A
Fixes #
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.