Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: remove mention of pod name is some alert messages #8168

Merged
merged 10 commits into from
Jul 4, 2024

Conversation

alex5517
Copy link
Contributor

@alex5517 alex5517 commented May 22, 2024

What this PR does

I found a few places where {{ $labels.pod }} is used in message, but the query removes it.

Which issue(s) this PR fixes or relates to

N/A

Fixes #
N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@alex5517 alex5517 requested a review from a team as a code owner May 22, 2024 11:17
@alex5517 alex5517 changed the title add per_instance_label to aggregation since it is used in alert template [mixin] add per_instance_label to aggregation since it is used in alert template May 22, 2024
@alex5517 alex5517 changed the title [mixin] add per_instance_label to aggregation since it is used in alert template mixin: add per_instance_label to aggregation since it is used in alert template May 23, 2024
@alex5517
Copy link
Contributor Author

@dimitarvdimitrov, Thanks i removed the per_instance_label and updated the message so it no longer included.

@dimitarvdimitrov dimitarvdimitrov changed the title mixin: add per_instance_label to aggregation since it is used in alert template mixin: remove mention of pod name is some alert messages Jul 4, 2024
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alex5517! LGTM

@dimitarvdimitrov dimitarvdimitrov merged commit c634c44 into grafana:main Jul 4, 2024
31 checks passed
@alex5517 alex5517 deleted the fix/missing-mixin-var branch September 3, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants