-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track custom anonymous usage statistics from ingester and querier #2685
Conversation
Signed-off-by: Marco Pracucci <marco@pracucci.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This was straightforward.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Helm <> Jsonnet Diff
If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag Please see the contribution docs here for more info. Expand to see the outputOutput of https://github.com/grafana/mimir/actions/runs/2834030252 Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
diff -r -u -N scratch/./helm/07-config/ingester-MimirConfig.yml scratch/./jsonnet/08-config/ingester-MimirConfig.yml
--- scratch/./helm/07-config/ingester-MimirConfig.yml 2022-08-10 16:05:30.469191258 +0000
+++ scratch/./jsonnet/08-config/ingester-MimirConfig.yml 2022-08-10 16:05:38.073325427 +0000
@@ -553,7 +553,7 @@
max_fetched_chunks_per_query: 2000000 (default)
max_fetched_series_per_query: 0 (default)
max_global_exemplars_per_user: 0 (default)
- max_global_series_per_metric: 20000 (default)
+ max_global_series_per_metric: 0
max_global_series_per_user: 150000 (default)
max_label_name_length: 1024 (default)
max_label_names_per_series: 30 (default)
diff -r -u -N scratch/./helm/07-config/overrides-exporter-MimirConfig.yml scratch/./jsonnet/08-config/overrides-exporter-MimirConfig.yml
--- scratch/./helm/07-config/overrides-exporter-MimirConfig.yml 2022-08-10 16:05:30.477191399 +0000
+++ scratch/./jsonnet/08-config/overrides-exporter-MimirConfig.yml 2022-08-10 16:05:38.077325499 +0000
@@ -498,7 +498,7 @@
max_fetched_chunks_per_query: 2000000 (default)
max_fetched_series_per_query: 0 (default)
max_global_exemplars_per_user: 0 (default)
- max_global_series_per_metric: 20000 (default)
+ max_global_series_per_metric: 0
max_global_series_per_user: 150000 (default)
max_label_name_length: 1024 (default)
max_label_names_per_series: 30 (default) |
What this PR does
In this PR I'm adding some custom metrics tracked by the anonymous usage stats tracker, that could help us better understand how Mimir is used (and its scale in the wild). The following custom metrics are tracked:
The
GetInt()
andGetCounter()
logic has been copied from Loki and I would like to keep it as closest as possible, to be able to move it to a common library in a follow up work.Known issue: if a report fails to send, we need to try to send the same exact report, because counters are reset each time we build a new one. I will do some refactoring to fix in a follow up PR.
Which issue(s) this PR fixes or relates to
Part of #1815.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]