-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Prometheus #233
Upgrade Prometheus #233
Conversation
23f9c55
to
2d094ea
Compare
The PR has been merged. To include it, I had to upgrade Alertmanager to latest main. Compared to 0.23.0 (which is the version against which I've checked the diff when I've opened the PR), the following changes have been introduced affecting us:
|
14096c8
to
415e7de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
@@ -527,6 +528,9 @@ func buildReceiverIntegrations(nc *config.Receiver, tmpl *template.Template, fir | |||
for i, c := range nc.PushoverConfigs { | |||
add("pushover", i, c, func(l log.Logger) (notify.Notifier, error) { return pushover.New(c, tmpl, l, httpOps...) }) | |||
} | |||
for i, c := range nc.SNSConfigs { | |||
add("sns", i, c, func(l log.Logger) (notify.Notifier, error) { return sns.New(c, tmpl, l, httpOps...) }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add "sns" into allowedIntegrationNames
in notifications_limit_flag.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, didn't see anything alarming in vendor changes.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
415e7de
to
17c22ee
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
What this PR does:
In this PR I'm upgrading Prometheus to latest
main
.The following Prometheus changes affect us:
There are 3 other PRs affecting TSDB, but these should affect only snapshotting which is a feature we're not using in Mimir yet:
This upgrades Alertmanager too, adding SNS receiver. Unfortunately the SNS receiver HTTP client is unused, so I've open an Alertmanager fix PR first (the PR is included in vendor/ changes here, so lint CI is expected to fail).
Other updated vendored libs:
IngestionAwareTransport
deprecation (we don't use it).Which issue(s) this PR fixes:
Fixes #192
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]