chore: Enable gosec G103 #10474
Open
chore: Enable gosec G103 #10474
+20
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
commented
Jan 17, 2025
|
|
||
| import "unsafe" | ||
|
|
||
| func YoloBuf(s string) []byte { |
There was a problem hiding this comment.
Decided against exporting this, as it still passes on certain usage requirements to its callers and yet the linter doesn't know to look for call sites. Exporting something that directly wraps a linter check felt against the spirit of the lint rule.
Comment on lines
+159
to
+160
| underlying := unsafe.Pointer(unsafe.SliceData(postings)) //nolint:gosec | ||
| return unsafe.Slice((*byte)(underlying), len(postings)*bytesPerPosting) //nolint:gosec |
There was a problem hiding this comment.
Modernized and avoiding deprecated types. This has an identical allocation profile to the original:
└──>go test ./pkg/storegateway/indexcache/... -bench BenchmarkCanonicalPostingsKey -run ^$ -benchmem
Before change:
BenchmarkCanonicalPostingsKey/10_postings-16 5908748 200.3 ns/op 96 B/op 2 allocs/op
BenchmarkCanonicalPostingsKey/100_postings-16 1346832 886.8 ns/op 96 B/op 2 allocs/op
BenchmarkCanonicalPostingsKey/1000_postings-16 163398 7304 ns/op 96 B/op 2 allocs/op
BenchmarkCanonicalPostingsKey/10000_postings-16 16560 72348 ns/op 96 B/op 2 allocs/op
BenchmarkCanonicalPostingsKey/100000_postings-16 1670 716915 ns/op 96 B/op 2 allocs/op
BenchmarkCanonicalPostingsKey/1000000_postings-16 163 7155922 ns/op 96 B/op 2 allocs/op
After change:
BenchmarkCanonicalPostingsKey/10_postings-16 6104720 193.4 ns/op 96 B/op 2 allocs/op
BenchmarkCanonicalPostingsKey/100_postings-16 1358037 882.1 ns/op 96 B/op 2 allocs/op
BenchmarkCanonicalPostingsKey/1000_postings-16 163988 7292 ns/op 96 B/op 2 allocs/op
BenchmarkCanonicalPostingsKey/10000_postings-16 16810 71467 ns/op 96 B/op 2 allocs/op
BenchmarkCanonicalPostingsKey/100000_postings-16 1678 713610 ns/op 96 B/op 2 allocs/op
BenchmarkCanonicalPostingsKey/1000000_postings-16 166 7138759 ns/op 96 B/op 2 allocs/op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Enables gosec G103, which checks for usages of unsafe.
Audited existing usages. In some cases, modernized memory-unsafe code to the newer go 1.20/1.22 mechanisms.
Which issue(s) this PR fixes or relates to
n/a
Checklist
n/a
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.