Sync prometheus #595
Merged
Sync prometheus #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Peterson <192540+captncraig@users.noreply.github.com>
This alert will never return anything as the left side of the query has the labels `[component, environment, instance, job, type]` while the right side has `[component, environment, instance, job]`. The `type` label was added to `prometheus_tsdb_head_samples_appended_total` in this PR but the mixin wasn't updated for the new label: prometheus/prometheus#11395 This was found with [pint](https://github.com/cloudflare/pint) PromQL linting Signed-off-by: Will Bollock <wbollock@linode.com>
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
For instance `require.NoError` will print the unexpected error; we don't need to include it in the message. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
…-dependency-controller Decouple ruler dependency controller from concurrency controller
…ples_label_matching mixin: PrometheusNotIngestingSamples label matching
storage/remote: apply custom headers before sigv4 transport
tests: Move from t.Errorf and others.
Document conditions on chunks. Add check on chunk time ordering. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
|
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got another Ruler PR merged upstream and in this PR I'm re-syncing Prometheus in our mimir-prometheus. The changeset is very small. A part from the ruler changes, there's a change in TSDB which adds an extra check when writing blocks.