operator: Add support for configuring HTTP server timeouts #9405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperimental
reviewed
May 11, 2023
xperimental
reviewed
May 17, 2023
There was a problem hiding this comment.
Left a few comments in the PR and made a branch with the goal of making the code simpler and avoiding a few indirections. Let me know what you think.
xperimental
reviewed
May 22, 2023
|
As I mentioned during the daily, I noticed that our defaults for |
xperimental
approved these changes
May 22, 2023
openshift-merge-robot
added a commit
to openshift/loki
that referenced
this pull request
May 23, 2023
[release-5.6] Backport PR grafana#9405
openshift-merge-robot
added a commit
to openshift/loki
that referenced
this pull request
May 23, 2023
[release-5.7] Backport PR grafana#9405
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The server-side timeout (read & write) have been so far constant not-aligned values, i.e. the lokistack-gateway used
12mand loki1m. This mismatch yields to server timeouts after one minute when doing long-range queries. This PR adds support to configure these values via the LokiStack custom resource. In addition it aligns the gateway's timeouts with those of Loki by reusing the latter and adding some wiggle room.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.md