-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Add support for memberlist bind network configuration #8672
Conversation
5b8fda0
to
5a84b6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1538b15
to
8fb50df
Compare
c75e311
to
c3aca20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I tried all the permutations of specifying options now... just a small improvement to the validation I came across and then we're good 🙂
Co-authored-by: Robert Jacob <xperimental@solidproject.de>
…ana#8672) Co-authored-by: Robert Jacob <xperimental@solidproject.de>
[release-5.6] Backport PR grafana#8672
What this PR does / why we need it:
This PR adds support to configure the memberlist
bind_addr
field using the pod network IP range instead of the default private network range used (See ). In managed Kubernetes/OpenShift cluster environments as well as in special on-prem setup the private IP range might not be available for using them. With this change set the LokiStack administrator can choose as a bind address the current pod network IP assigned by the cluster's pod network.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updateddocs/sources/upgrading/_index.md