Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki: Renames metric 'loki_log_messages_total' to 'loki_internal_log_messages_total' #7361

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

aurifi
Copy link
Contributor

@aurifi aurifi commented Oct 6, 2022

What this PR does / why we need it:
Renames the metric 'loki_log_messages_total' to a more descriptive name.
Keeps and deprecates the previously existing metric to not break functionality.

Which issue(s) this PR fixes:
Fixes #7088

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 6, 2022
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@pull-request-size pull-request-size bot added size/M and removed size/L labels Oct 6, 2022
This metric is meant as a replacement for the metric log_messages_total
the metric log_messages_total will be deprecated in the future due to
ambiguity
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@aurifi aurifi marked this pull request as ready for review October 6, 2022 19:30
@aurifi aurifi requested a review from a team as a code owner October 6, 2022 19:30
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @szczepad. wondering if it's really worth changing this metric name, given we have accurate help message and description.

trying to understand your actual pain point here :)

Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. my bad. Just read the original issue for more context.

LGTM.

@kavirajk kavirajk merged commit 4e61c60 into grafana:main Oct 11, 2022
lxwzy pushed a commit to lxwzy/loki that referenced this pull request Nov 7, 2022
…messages_total' (grafana#7361)

**What this PR does / why we need it**:
Renames the metric 'loki_log_messages_total' to a more descriptive name.
Keeps and deprecates the previously existing metric to not break
functionality.

**Which issue(s) this PR fixes**:
Fixes grafana#7088 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the `CONTRIBUTING.md` guide
- [x] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`
changhyuni pushed a commit to changhyuni/loki that referenced this pull request Nov 8, 2022
…messages_total' (grafana#7361)

**What this PR does / why we need it**:
Renames the metric 'loki_log_messages_total' to a more descriptive name.
Keeps and deprecates the previously existing metric to not break
functionality.

**Which issue(s) this PR fixes**:
Fixes grafana#7088 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the `CONTRIBUTING.md` guide
- [x] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
…messages_total' (grafana#7361)

**What this PR does / why we need it**:
Renames the metric 'loki_log_messages_total' to a more descriptive name.
Keeps and deprecates the previously existing metric to not break
functionality.

**Which issue(s) this PR fixes**:
Fixes grafana#7088 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the `CONTRIBUTING.md` guide
- [x] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 bc-break size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change metric log_messages_total into something more clear
5 participants