Add API delete curl examples #6680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
- loki -0.6% |
MasslessParticle
approved these changes
Jul 14, 2022
Co-authored-by: Jennifer Villa <jvilla2013@gmail.com>
Co-authored-by: Jennifer Villa <jvilla2013@gmail.com>
Co-authored-by: Jennifer Villa <jvilla2013@gmail.com>
Co-authored-by: Jennifer Villa <jvilla2013@gmail.com>
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
grafanabot
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Add API delete curl examples * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> (cherry picked from commit 1f676ad)
KMiller-Grafana
added a commit
that referenced
this pull request
Jul 14, 2022
* Add API delete curl examples * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> (cherry picked from commit 1f676ad) Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
| ```bash | ||
| curl -u "Tenant1:$API_TOKEN" \ | ||
| -g -X POST \ | ||
| 'http://127.0.0.1:3100/loki/api/v1/delete?query={foo="bar"}&start=1591616227&end=1591619692' |
There was a problem hiding this comment.
We've found out that running these kinds of post requests in bash causes problems with escaping the &, = and characters. The --data-urlencode parameter for curl is preferred. https://github.com/grafana/deployment_tools/blob/master/docs/loki/support-escalation.md#manual-operational-tasks has an example. Perhaps we should use that format.
lxwzy
pushed a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
* Add API delete curl examples * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Update docs/sources/api/_index.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> Co-authored-by: Jennifer Villa <jvilla2013@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates API delete examples (documentation) in the same way that PR #6530 updated the API query example. Deletes only work on a single tenant, so the examples distinguish GEL API header from Loki headers.
Reviews: