add metrics for tracking index shipper operations #6278
Conversation
| @@ -0,0 +1,36 @@ | |||
| package downloads | |||
There was a problem hiding this comment.
| @@ -0,0 +1,25 @@ | |||
| package uploads | |||
There was a problem hiding this comment.
old metrics.go for reference https://github.com/grafana/loki/blob/440fb7d74cad481bebb222b21fc063fa56c2f5ac/pkg/storage/stores/shipper/uploads/metrics.go
openExistingFileFailuresTotal is only relevant for boltdb-shipper so it is already added to it here
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
| for _, table := range tm.tables { | ||
| err := table.Upload(ctx) | ||
| if err != nil { | ||
| status = statusFailure |
There was a problem hiding this comment.
Q: can this be confusing when only few tables failed to upload. But in the metrics, we record as though everything is failed?
tm.metrics.tablesUploadOperationTotal.WithLabelValues(status).Inc()
There was a problem hiding this comment.
We track the overall upload operation. We can count individual table upload operations as well but the investigator would anyways have to check the logs to find more details about it.
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
What this PR does / why we need it:
In PR #6226, we refactored the code to make the
boltdb-shipperindex client use the genericindexshipperto manage the index on object storage. This PR takes care of follow up action to add metrics toindexshipper.I have made sure we have the same metrics exposed as before by using
WrapRegistererWithPrefix, i.e. when usingindexshipperforboltdb-shipper, metrics would be prefixed withloki_boltdb_shipper_while fortsdb, the prefix would beloki_tsdb_shipper_