Fix label extraction pushdown on instant queries #6215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0.1%
+ loki 0% |
1304c16 to
8c8bc11
Compare
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0.1%
+ loki 0% |
chaudum
approved these changes
May 23, 2022
Comment on lines
+346
to
+349
| // Downstream queries with label extractors can potentially produce a huge amount of series | ||
| // which can impact the queries and consequently fail. | ||
| // Note: vector aggregation expressions aggregate the result in a single empty label set, | ||
| // so these expressions can be pushed downstream |
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the context of instant queries with label extractors logfmt & json, when combining range vector aggregators
bytes_over_time,count_over_time,rateandbytes_ratewith vector aggregatorsmaxandmin, it is not possible to usesumas aggregation operator for downstream queries results. This results from the recent change to push downstream vector aggregator expressions: #6132List of failing tests: https://drone.grafana.net/grafana/loki/12011/2/5
This PR uses only
concatas a downstream aggregation operator for expressions of the following types:Note: since
rateandbytes_raterange vector aggregator expressions are converted internally to a binary operation, these expressions return noop when inside amaxorminvector aggregator with a label extraction operator.Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md