Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Reimplement PR 5649 on troubleshooting timeout errors #6183

Merged
merged 1 commit into from
May 26, 2022

Conversation

KMiller-Grafana
Copy link
Contributor

After PR 5649 submission and before approval, the directory structure of the docs changed, making a merge of #5649 impossible without a rework.

This PR is the work of @gmintoco. I've put in substantial edits on the original prose from PR 5649.

@KMiller-Grafana
Copy link
Contributor Author

@gmintoco, would you review my changes?

@KMiller-Grafana KMiller-Grafana requested a review from a team May 17, 2022 22:16
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@kavirajk
Copy link
Contributor

@KMiller-Grafana I think it would be fair to include original commit from @gmintoco and change the location of the file on top of it.

@gmintoco
Copy link

lgtm @KMiller-Grafana

@kavirajk kavirajk merged commit 0b947d9 into grafana:main May 26, 2022
@KMiller-Grafana KMiller-Grafana deleted the docs/reimplement-pr5649 branch June 7, 2022 16:42
@osg-grafana osg-grafana added type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories and removed area/docs labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants