Remove unused grpc health check methods #6113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have generic `grpc_healthcheck` endpoint that get registered for all the components during initialization stage. Looks like these health checks that are part of actual component's struct itself came from legacy. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0.1%
+ distributor 1%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
chaudum
approved these changes
May 6, 2022
owen-d
approved these changes
May 6, 2022
| // Check implements grpc_health_v1.HealthCheck. | ||
| func (i *Ingester) Check(ctx context.Context, req *grpc_health_v1.HealthCheckRequest) (*grpc_health_v1.HealthCheckResponse, error) { | ||
| status := grpc_health_v1.HealthCheckResponse_SERVING | ||
| if (i.State() != services.Running) || (i.lifecycler.GetState() != ring.ACTIVE) { |
There was a problem hiding this comment.
I'm a bit worried that we don't seem to be checking the lifecycler state in our blanket version, but it doesn't look like these are used either.
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have generic
grpc_healthcheckendpoint that get registered for all the componentsduring initialization stage.
https://github.com/grafana/loki/blob/main/pkg/loki/loki.go#L364
Looks like these old health checks that are part of actual component's struct itself came from legacy.
Signed-off-by: Kaviraj kavirajkanagaraj@gmail.com
NOTE: This should be no op. No build or test failure as there are no consumer for these methods
Which issue(s) this PR fixes:
Fixes # NA
Special notes for your reviewer:
We figured this out while investigating this ingester/querier grpc issue #6023
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md