renames skip -> ok in ProcessString #6064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
|
What about 'matched' instead of 'ok' ? |
|
I hear you but not sure ok does a better job no ? The point is that the line is filtered out. |
|
I was being lazy trying to avoid replacing all the other references which already use |
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
267d114 to
0532f5c
Compare
…-name Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This confuses me every now and then, so I fixed the method var name and the last 2 references that used it as the name
skip. Looking at how it's used, it should be namedokorkeeporpasses.