index-gateway: fix index gateway chunk refs response #5957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find! Do we have a test where we check the correctness of the chunk refs response? |
No, sorry, we don't have any such tests for index gateway. I just want to unblock our internal release for now. I won't be able to work on tests today. We can open an issue so that we don't forget adding them. |
chaudum
approved these changes
Apr 19, 2022
|
Here is the issue for tracking #5958 |
chaudum
pushed a commit
that referenced
this pull request
Apr 19, 2022
chaudum
pushed a commit
that referenced
this pull request
Apr 19, 2022
|
Awesome I think we should have added a test too. If anyone want to take a stab at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While building
GetChunkRefsresponse from index gateways, we by mistake used the address of the loop variable. This causes us to have the same values for all the chunks. Lint somehow missed catching that mistake. This PR fixes the issue by using index for getting the address of the slice item.