operator: Bump operator-sdk to v1.19.1 #5929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
reviewed
Apr 15, 2022
Comment on lines
+584
to
+591
| - label: | ||
| app.kubernetes.io/instance: loki-operator-v0.0.1 | ||
| app.kubernetes.io/managed-by: operator-lifecycle-manager | ||
| app.kubernetes.io/name: loki-operator | ||
| app.kubernetes.io/part-of: cluster-logging | ||
| app.kubernetes.io/version: 0.0.1 | ||
| control-plane: controller-manager | ||
| name: loki-operator-controller-manager |
There was a problem hiding this comment.
Do we want do have the labels back here cc @xperimental ?
There was a problem hiding this comment.
These labels should be fine as they are the labels on the Deploment itself and not the selector used for finding the pods (a few lines below). I had wondered why the Deployment had so few labels on my PR related to the selector, so this is better than before from my point of view.
periklis
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the operator-sdk to v1.19.1. This update fixes a bug with generating the bundle.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.