Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golang version to v1.17.9 #5899

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Upgrade golang version to v1.17.9 #5899

merged 1 commit into from
Apr 13, 2022

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Apr 13, 2022

This updates golang version to v1.17.9

https://groups.google.com/g/golang-announce/c/oecdBNLOml8

git ls-files  '*[Dd]ockerfile*' | grep -v ^vendor/ | xargs sed -i "s/golang:[0-9\\.]*/golang:1.17.9/g" | ag 'golang:'

```
git ls-files  '*[Dd]ockerfile*' | grep -v ^vendor/ | xargs sed -i "s/golang:[0-9\\.]*/golang:1.17.9/g" | ag 'golang:'
```
@simonswine simonswine marked this pull request as ready for review April 13, 2022 08:07
@simonswine simonswine requested a review from a team as a code owner April 13, 2022 08:07
@@ -1,5 +1,5 @@
# Build the manager binary
FROM golang:1.17 as builder
FROM golang:1.17.9 as builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me! We are thankful for getting this bits in sync with Loki! 👏

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@periklis
Copy link
Collaborator

@simonswine Do we add changelog entries for such PRs?

@cyriltovena cyriltovena merged commit 9d0fd3a into main Apr 13, 2022
@cyriltovena cyriltovena deleted the 20220413_golang-1.17.9 branch April 13, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants