Ensure proto definitions are formatted [1/2] #5785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you seen this https://buf.build/blog/introducing-buf-format it's super recent but wonder if that's easier . |
420fc04 to
a757403
Compare
This is part 1 of 2 PRs and updates the build image to version 0.10.4 and adding the buf utility which will later be used for formatting *.proto files
a757403 to
d61fc31
Compare
Thanks for the hint, I was not aware of it 🙂 |
owen-d
approved these changes
Apr 22, 2022
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It will ensure that our proto files follow a consistent formatting throughout.
This PR adds
bufto the build image and will be followed by the usage of buf in #6000Special notes for your reviewer:
This is the first in a series two PRs (second being #6000)
Checklist
- [ ] Documentation added- [ ] Tests updated- [ ] Add an entry in theCHANGELOG.mdabout the changes.