-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: make Azure blobID chunk delimiter configurable #5777
storage: make Azure blobID chunk delimiter configurable #5777
Conversation
@ronyrv13 Feel free to add or change anything in this PR. |
72f69af
to
800519a
Compare
Hello @tatchiuleung I have tested loki with this PR changes, and it really worked. Old Logs Chunks which was successfully fetched - chunk_delimiter config set to "-" Latest logs also Fetched successfully- cc: @dannykopping |
Loki Config Used- storage_config:
azure:
container_name: ${CONTAINER_NAME}
account_name: ${STORAGE_ACCOUNT_NAME}
account_key: ${STORAGE_ACCOUNT_KEY}
chunk_delimiter: ":"
boltdb_shipper:
shared_store: azure
index_queries_cache_config: |
@ronyrv13 Thank you for the test! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR! Can you please resolve conflicts with changelog so that I can merge this? |
@sandeepsukhani Done! |
Apologies for not reviewing this PR - I was on vacation this week. Thanks a lot! |
Thanks @tatchiuleung and @ronyrv13 for contribution to make working chunk_delimiter: ":". |
What this PR does / why we need it:
Make the
-
chunk delimiter configurable, instead of hardcoded one-
.Which issue(s) this PR fixes:
Fixes #5712
Special notes for your reviewer:
@dannykopping @khaines I would appreciate if you can review it. Thank you!
Checklist
CHANGELOG.md
about the changes.