Preserve interval parameter when splitting queries by time #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
added a commit
that referenced
this pull request
Mar 14, 2022
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
|
Adding @slim-bean as reviewer, since the |
|
Just need to resolve conflict I enable auto merge. |
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
dbc1fb2 to
7314e29
Compare
grafanabot
pushed a commit
that referenced
this pull request
Apr 7, 2022
* Preserve interval parameter when splitting queries by time Signed-off-by: Christian Haudum <christian.haudum@gmail.com> * Add tests for interval param on Loki downstream requests Signed-off-by: Christian Haudum <christian.haudum@gmail.com> * Add changelog entry for #5622 Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit 95b8856)
slim-bean
pushed a commit
that referenced
this pull request
Apr 7, 2022
…5815) * Preserve interval parameter when splitting queries by time Signed-off-by: Christian Haudum <christian.haudum@gmail.com> * Add tests for interval param on Loki downstream requests Signed-off-by: Christian Haudum <christian.haudum@gmail.com> * Add changelog entry for #5622 Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit 95b8856) Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
splitice
pushed a commit
to X4BNet/loki
that referenced
this pull request
May 21, 2022
) (grafana#5815) * Preserve interval parameter when splitting queries by time Signed-off-by: Christian Haudum <christian.haudum@gmail.com> * Add tests for interval param on Loki downstream requests Signed-off-by: Christian Haudum <christian.haudum@gmail.com> * Add changelog entry for grafana#5622 Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit 95b8856) Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the incorrect behaviour where the
intervalparameter from a query range request is ignored in case the query is internally split by time, and therefore returning much more results than expected.Which issue(s) this PR fixes:
Fixes #5613
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.