Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move -querier.split-queries-by-interval into limits config #5233

Closed

Conversation

trevorwhitney
Copy link
Collaborator

@trevorwhitney trevorwhitney commented Jan 25, 2022

What this PR does / why we need it:

Now that we have forked the queryrange package directly into Loki, we can remove this flag from queryrange since we are already giving precedence to the limits value of the same name. By moving the the flag to the limits config, existing configs will work the same way, but the enforcement is now coming via limits and is overridable per tenant.

Special notes for your reviewer:

I removed some code from queryrangebase that I could not find any references to. Please let me know if this code is being used outside Loki.

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@trevorwhitney trevorwhitney requested a review from a team as a code owner January 25, 2022 23:44
@ssncferreira
Copy link
Contributor

@trevorwhitney it seems this is a duplicated of: #5184

@trevorwhitney
Copy link
Collaborator Author

Indeed it is, closing. the one difference here @ssncferreira is the decision not to deprecate but move the flag, so I added a question to #5184 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants