Store metrics queueTime in seconds #5052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
metrics.go
statisticqueueTime
was introduced in #4949. In this PR, the metric was stored in nanoseconds as int64:loki/pkg/logqlmodel/stats/stats.pb.go
Line 102 in cecadf2
However, the statistics result struct:
loki/pkg/logqlmodel/stats/stats.pb.go
Lines 30 to 34 in cecadf2
is used both for internal calculations and for API responses. Grafana uses these returned statistics from the API and expects time values to be returned in seconds as float. This PR converts the
queueTime
metric to be stored in seconds as float.By storing time values in seconds as
float64
, the minimum value second we can store is2.2E-308
(range for float64), which is2.2E-299
nanoseconds. This means that we won’t lose precision when logging values less than a second or when sending the API response.Special notes for your reviewer:
Checklist
CHANGELOG.md
about the changes.