Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds replication_factor doc to common config #4683

Merged
merged 1 commit into from
Nov 7, 2021
Merged

Adds replication_factor doc to common config #4683

merged 1 commit into from
Nov 7, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Nov 6, 2021

Oops, looks like we missed adding this to the configuration docs.

@owen-d @slim-bean
Adds replication_factor doc to common config
e350a21 
Oops, looks like we missed adding this to the configuration docs.
slim-bean
slim-bean approved these changes Nov 7, 2021
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit e52e805 into main Nov 7, 2021
@slim-bean slim-bean deleted the owen-d-patch-1 branch November 7, 2021 23:54
grafanabot pushed a commit that referenced this pull request Nov 7, 2021
@owen-d @grafanabot
Adds replication_factor doc to common config (#4683)
4b68509 
Oops, looks like we missed adding this to the configuration docs.

(cherry picked from commit e52e805)
@grafanabot grafanabot mentioned this pull request Nov 7, 2021
Merged
slim-bean pushed a commit that referenced this pull request Nov 8, 2021
@grafanabot @owen-d
Adds replication_factor doc to common config (#4683) (#4691)
17906e3 
Oops, looks like we missed adding this to the configuration docs.

(cherry picked from commit e52e805)

Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

@KMiller-Grafana KMiller-Grafana Awaiting requested review from KMiller-Grafana

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-d @slim-bean