Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves memchunk benchmark to account for block size. #4645

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

cyriltovena
Copy link
Contributor

No major code change except some cleanup.

none_524 kB: 3952.20 MB/s
none_262 kB: 3818.19 MB/s
none_262 kB: 3588.39 MB/s
none_524 kB: 3528.82 MB/s
none_66 kB: 3347.10 MB/s
none_66 kB: 3306.29 MB/s
none_524 kB: 3052.64 MB/s
none_262 kB: 2932.31 MB/s
lz4-1M_66 kB: 2567.87 MB/s
lz4_262 kB: 2467.42 MB/s
none_66 kB: 2453.80 MB/s
lz4-256k_524 kB: 2398.77 MB/s
lz4-1M_262 kB: 2295.78 MB/s
lz4-256k_524 kB: 2289.92 MB/s
lz4-256k_262 kB: 2281.90 MB/s
lz4-1M_524 kB: 2213.51 MB/s
lz4-256k_66 kB: 2187.04 MB/s
lz4_524 kB: 2183.28 MB/s
lz4_524 kB: 2177.57 MB/s
lz4-1M_66 kB: 2148.51 MB/s
lz4_66 kB: 2145.61 MB/s
lz4-1M_262 kB: 2120.39 MB/s
sample_none_66 kB: 2104.96 MB/s
lz4-64k_66 kB: 2098.88 MB/s
lz4-64k_524 kB: 2077.25 MB/s
lz4-64k_524 kB: 2073.97 MB/s
lz4-256k_66 kB: 2070.37 MB/s
lz4_262 kB: 2052.62 MB/s
lz4-256k_262 kB: 2030.32 MB/s
lz4_66 kB: 2013.14 MB/s
lz4-64k_262 kB: 2009.75 MB/s
lz4_262 kB: 1998.54 MB/s
lz4-64k_66 kB: 1992.59 MB/s
lz4-64k_262 kB: 1942.55 MB/s
lz4-1M_524 kB: 1914.17 MB/s
lz4-256k_262 kB: 1865.59 MB/s
snappy_524 kB: 1859.09 MB/s

Interesting to see lz4 beating snappy now.

I'm guessing this is due to the an upgrade of the vendor code.

As for size lz4 has a compression ratio of 13 vs 9 for snappy.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena requested a review from a team as a code owner November 4, 2021 16:49
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 11071d4 into grafana:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants